fix: use latest tag line "better" -> "fast, modern"#1029
fix: use latest tag line "better" -> "fast, modern"#1029danielroe merged 7 commits intonpmx-dev:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
📝 WalkthroughWalkthroughThis pull request updates wording across the codebase: the product tagline and related description text were changed from "A better browser for the npm registry" to "a fast, modern browser for the npm registry". Changes appear in Vue components (Open Graph/Default), multiple email templates, and localisation JSON files (en.json, en-GB.json, en-US.json). No control-flow, logic, interface signatures, or public/exported entity declarations were modified. Suggested reviewers
🚥 Pre-merge checks | ✅ 1✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
assets/email-templates/reset-password.html (1)
154-160:⚠️ Potential issue | 🟡 MinorFix typo in the footer tagline.
The word “registryt” should be “registry”.🔧 Proposed fix
- >, a fast, modern browser for the npm registryt + >, a fast, modern browser for the npm registry
🧹 Nitpick comments (2)
i18n/locales/en.json (1)
5-5: Minor text redundancy (optional consideration).The description now contains "modern" twice: "a fast, modern browser" and "with a modern interface". This is not a blocker, but you might consider rewording the second part to avoid repetition, e.g., "with a sleek interface" or "with a clean interface".
lunaria/files/en-US.json (1)
5-5: Same text redundancy as en.json.This has the same "modern" repetition as
i18n/locales/en.json. If you decide to address the redundancy, ensure both files are updated consistently.
|
Might be a good idea to ask in the Discord for translations on this PR. |
shuuji3
force-pushed
the
fix/new-tagline
branch
from
37d8837 to
a5239e6
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
assets/email-templates/reset-password.html (1)
154-160:⚠️ Potential issue | 🟡 MinorFix typo in footer tagline (“registryt”).
Line 159 has a stray “t” at the end of “registry”.[suggested fix]
🛠️ Proposed fix
- >, a fast, modern browser for the npm registryt + >, a fast, modern browser for the npm registry
|
OpenGraph image is still "better" one: (https://npmxdev-git-fork-shuuji3-fix-new-tagline-poetry.vercel.app/__og-image__/image/og.png) |
Co-authored-by: Daniel Roe <daniel@roe.dev>
Co-authored-by: Daniel Roe <daniel@roe.dev>
Co-authored-by: Daniel Roe <daniel@roe.dev>
|
I can see a correct og image on localhost. Appearently, it's a preview build cache? 
|
|
Thanks, I'll watch if all translations will be updated and ping them later if not updated for a while (at least until March 3rd). |
3 participants
This PR replace the all previous tagline with the new one.
Before
After
TODO: